Roy Golan has posted comments on this change. Change subject: core, engine: sPAPR SCSI on PPC64 VMs ......................................................................
Patch Set 3: Code-Review+1 (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskInterface.java Line 5: Line 6: public enum DiskInterface { Line 7: Line 8: IDE("ide", "ide"), Line 9: VirtIO_SCSI("virtio-scsi", "scsi"), My bad. whats in use is the interfaceName which is now being used in VmInfoBuilder. so the change is ok. Line 10: VirtIO("virtio", "virtio"), Line 11: SPAPR_VSCSI("spapr-vscsi", "scsi"); Line 12: Line 13: private String name; -- To view, visit http://gerrit.ovirt.org/18622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4fefa225cb44f0e09a7a056e07b8393dda6819b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches