Roy Golan has posted comments on this change. Change subject: core: [Fix] Add host hotplug support checks ......................................................................
Patch Set 9: (1 comment) .................................................... File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java Line 403: * check that hotplug is enabled via the 3.1 config paramter {@literal ConfigValues.HotPlugEnabled, Line 404: * @return Line 405: */ Line 406: protected boolean isHotPlugSupported() { Line 407: if (FeatureSupported.hotPlug(getVds().getVdsGroupCompatibilityVersion())) { that check is not needed anymore as osrepository reflects the support per architecture and version. Line 408: return true; Line 409: } Line 410: Line 411: return failCanDoAction(VdcBllMessages.HOT_PLUG_IS_NOT_SUPPORTED); -- To view, visit http://gerrit.ovirt.org/21266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e4c8409c0de4ff1c959d27b54e793a31654326c Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: liron aravot <liron.ara...@gmail.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches