Arik Hadas has posted comments on this change.

Change subject: core: refactor the scheduling call on run vm flow
......................................................................


Patch Set 5:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
Line 612:         setVdsName(null);
Line 613: 
Line 614:         setVdsId(schedule());
Line 615: 
Line 616:         if (Guid.Empty.equals(getVdsId())) {
see AuditLogableBase#getVdsId, if the scheduler returns null as the vds id (if 
no host can be selected) then we get empty guid here
Line 617:             throw new 
VdcBLLException(VdcBllErrors.RESOURCE_MANAGER_CANT_ALLOC_VDS_RUN);
Line 618:         }
Line 619: 
Line 620:         if (getVds() == null) {


-- 
To view, visit http://gerrit.ovirt.org/22100
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63c0f62346cd9a95fc612648b0070722878a4d90
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to