Yair Zaslavsky has posted comments on this change.
Change subject: tools: Adds option MAIL_SMTP_ENCRYPTION to notifier
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java
Line 189: /**
Line 190: * Returns {@code true}, mail transport encryption type {@link
MAIL_SMTP_ENCRYPTION} is set to none
Line 191: * {@link MAIL_SMTP_ENCRYPTION_NONE}
Line 192: */
Line 193: public boolean isSmtpEncryptionNone() {
Don't you want to have one method for this? it's up to you..
the method can accept as argument the expected value ...
Line 194: return
MAIL_SMTP_ENCRYPTION_NONE.equals(getProperty(MAIL_SMTP_ENCRYPTION, true));
Line 195: }
Line 196:
Line 197: /**
--
To view, visit http://gerrit.ovirt.org/22296
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a914091060c0a86b2710ce20e666d67f28fa401
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Martin Peřina <mper...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: mooli tayer <mta...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
