Ravi Nori has posted comments on this change.
Change subject: webadmin: Dashboard results an error, when reports is not
deployed
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/MainTabReportsPresenter.java
Line 117: super.onReset();
Line 118: if (!hasReportsModelRefreshEvent()) {
Line 119: reportsWebappDeployed = false;
Line 120: getModel().getReportModelRefreshEvent().addListener(new
ReportsModelRefreshEvent());
Line 121: }
If I don't have the above check and registration the following case does not
work.
1. Login to webadmin
2. Restart ovirt-engine
3. Redirected to login page
4. Login to webadmin
5. Click on dashboard tab
Nothing happens, on debugging I see the listeners list is empty. Do we need to
handle this case?
Line 122: setSubTabPanelVisible(false);
Line 123: getModel().refreshReportModel();
Line 124: }
Line 125:
--
To view, visit http://gerrit.ovirt.org/22279
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6f63fe75110a6f799d355e78ed1fc0af2bd7d06
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
