Allon Mureinik has posted comments on this change.
Change subject: core: use OsInfo instead of config value
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Looks good to me (except for the nit inline).
Roy?
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/VmValidationUtils.java
Line 42: *
Line 43: * @return If the OS type is supported.
Line 44: */
Line 45: public static boolean isOsSupportedForVirtIoScsi(int osId, Version
clusterVersion) {
Line 46: ArrayList<String> diskInterfaces =
SimpleDependecyInjector.getInstance().get(OsRepository.class).getDiskInterfaces(osId,
clusterVersion);
Don't count on this being an ArrayList - use a List
Line 47: return
diskInterfaces.contains(DiskInterface.VirtIO_SCSI.toString());
Line 48: }
Line 49:
Line 50: /**
--
To view, visit http://gerrit.ovirt.org/22216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf434c5b7907f413399890a4b2e7d9f63f2bce9a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
