Oved Ourfali has posted comments on this change.
Change subject: core: adding remote console related events
......................................................................
Patch Set 1:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java
Line 195: @Override
Line 196: public void processOnClientIpChange(final VDS vds, final Guid
vmId) {
Line 197: final VmDynamic vmDynamic =
DbFacade.getInstance().getVmDynamicDao().get(vmId);
Line 198: final AuditLogableBase event = new AuditLogableBase();
Line 199: event.setVmId(vmId);
The VM ID is enough in this case, as the code for vmName is:
if (mVmName == null && getVm() != null) {
mVmName = getVm().getName();
}
return mVmName;
and getVm() will read the VM from the database using the VM ID.
Line 200: event.setUserName(vmDynamic.getConsoleCurrentUserName());
Line 201:
Line 202: // in case of empty clientIp we clear the logged in user.
Line 203: // (this happened when user close the console to spice/vnc)
....................................................
File
backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
Line 705: DISK_ALIGNMENT_SCAN_START=Starting alignment scan of disk
'${DiskAlias}'.
Line 706: DISK_ALIGNMENT_SCAN_FAILURE=Alignment scan of disk '${DiskAlias}'
failed.
Line 707: DISK_ALIGNMENT_SCAN_SUCCESS=Alignment scan of disk '${DiskAlias}' is
complete.
Line 708: VM_MEMORY_NOT_IN_RECOMMENDED_RANGE=VM ${VmName} was configured with
${VmMemInMb}mb of memory while the recommended value range is ${VmMinMemInMb}mb
- ${VmMaxMemInMb}mb
Line 709: VM_CONSOLE_CONNECTED=User ${UserName} is connected to VM ${VmName}.
See response in the VdsEventListener, where I fire the log.
--
To view, visit http://gerrit.ovirt.org/22223
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id345f413f83d82ef3a14fa35c1be7b65699d3298
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
