Yair Zaslavsky has posted comments on this change. Change subject: core: Added VdcUser.isAdmin() ......................................................................
Patch Set 3: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/IVdcUser.java Line 40: void setIsAdmin(boolean isAdmin); Small comment - Is this considered ok according to java convention? For some reason i thought a getter of boolean is either isXXX or getXXX and that the seter is setXXX - i.e should be isAdmin and setAdmin. -- To view, visit http://gerrit.ovirt.org/3952 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I045cfbf4d16cfbb49960fc43f9793a611b4e30dc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
