Allon Mureinik has posted comments on this change. Change subject: engine: Add checkstyle rule EqualsHashCode ......................................................................
Patch Set 1: (1 comment) .................................................... File build-tools-root/checkstyles/src/main/resources/checkstyle.xml Line 36: </module> Line 37: <module name="checks.NoArgConstructorCheck"> Line 38: <property name="run" value="${checkNoArgConstructor}" default="false"/> Line 39: </module> Line 40: <module name="EqualsHashCode"/> Please move this before NlsCheck - lets keep a separation between builtin checkstyles and oVirt ones. Line 41: </module> -- To view, visit http://gerrit.ovirt.org/22266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id7f270aa850529e1894fe3fd6198930b1844402b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches