Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: Clean up treatment of /etc/exports
......................................................................
Patch Set 4:
(1 comment)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/exportfs.py
Line 57: if matcher and matcher.group('path') == path:
Line 58: ret = index
Line 59: return ret
Line 60:
Line 61: def _get_and_delete_exports_path(self, path, conf, modifiedList):
well, the whole point was to remove this function... something like:
content = []
with open(exports) as f:
content = f.read...
index = find_path(content, path)
if exports.d:
if index is not None:
del content[index]
write exports.d
else:
if index is None:
content.append(line)
write content to exports (if not changed nothing will happen)
Line 62: ret = ''
Line 63: conf_content = []
Line 64: if os.path.exists(conf):
Line 65: with open(conf, 'r') as src_file:
--
To view, visit http://gerrit.ovirt.org/20709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I035817c048518f77fc666cc6d5212c8e46edd65d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
