Shireesh Anjal has posted comments on this change.
Change subject: restapi: Gluster REST api - Create Gluster Volume
......................................................................
Patch Set 3: (1 inline comment)
Eoghan, I will send a patch-set with the JUnit test.
Ori, important response inline regarding creating empty volume.
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
Line 49:
In case of Gluster, it is not only meaningless, but also impossible to create a
volume without bricks. Our "Create Volume" command is going to issue a
corresponding Gluster CLI command, which will fail if you don't pass the bricks.
So we will need to pass the bricks when we create a volume. Afterwards, it is
possible to "expand" the volume by adding more bricks to it. For this, the POST
api on .../glustervolumes/{glustervolume:id}/bricks will be used.
--
To view, visit http://gerrit.ovirt.org/3932
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I578f5b7ea0328057d2e29d04a31393856b021f08
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Eoghan Glynn <eoghan.gl...@gmail.com>
Gerrit-Reviewer: Ori Liel <ol...@redhat.com>
Gerrit-Reviewer: Shireesh Anjal <san...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
