Doron Fediuck has posted comments on this change. Change subject: engine: vds_installer fix ......................................................................
Patch Set 1: (2 inline comments) .................................................... File backend/manager/conf/vds_installer.py Line 228: execfn += ["-V"] I'm missing some context here; should this work with both new and older scripts? IE- will it not break already installed hosts with older vds_bootstrap* scripts? Line 331: """Usage: vds_installer.py [-c vds_config_str] [-m remote_nfs] [-r rev_num] [-O organizationName] [-t YYYY-MM-DDTHH:mm:SS_system_time] [-p engine_port] [-V] [-g] <url_bs> <url_rpm> <vds_server> <random_num> <vds_complete> I think it's a good opportunity to add your -V to this documentation, so readers can understand its a negation verb. -- To view, visit http://gerrit.ovirt.org/4053 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92c714345802e12a2e84074e65e6f409f26f6653 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Haim Ateya <hat...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
