Ramesh N has uploaded a new change for review.
Change subject: gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase
......................................................................
gluster: fix findBug warning in GlusterAsyncTaskStatusQueryBase
filling the task parameter after the null check for task and
task ID.
Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115
Signed-off-by: Ramesh Nachimuthu <rnach...@redhat.com>
---
M
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/22227/1
diff --git
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
index 8cd6d04..6bad44b 100644
---
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
+++
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
@@ -109,11 +109,12 @@
private void updateLatestStatus(GlusterVolumeTaskStatusEntity status) {
GlusterAsyncTask asyncTask = volume.getAsyncTask();
- GlusterTaskParameters taskParameters = new GlusterTaskParameters();
- taskParameters.setVolumeName(volume.getName());
- asyncTask.setTaskParameters(taskParameters);
if (asyncTask != null && asyncTask.getTaskId() != null) {
+ GlusterTaskParameters taskParameters = new GlusterTaskParameters();
+ taskParameters.setVolumeName(volume.getName());
+ asyncTask.setTaskParameters(taskParameters);
+
List<Step> stepsList =
getStepDao().getStepsByExternalId(asyncTask.getTaskId());
asyncTask.setStatus(status.getStatusSummary().getStatus());
--
To view, visit http://gerrit.ovirt.org/22227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibeca077dc4fbc1f8d546f8aea0482c41300cb115
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
