Sahina Bose has posted comments on this change. Change subject: gluster: add force support to add-bricks ......................................................................
Patch Set 10: (2 comments) .................................................... Commit Message Line 7: gluster: add force support to add-bricks Line 8: Line 9: 'create volume' and 'add-brick' operation in gluster will fail, Line 10: if the brick directories are in root partition. Line 11: 'force' option added to skip the above check if required. Also, mention that force option will clear any xattr. Line 12: Line 13: Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131 Line 14: Bug-Url: https://bugzilla.redhat.com/1008942 .................................................... File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AddBricksToGlusterVolumeVDSCommand.java Line 14: @Override Line 15: protected void executeVdsBrokerCommand() { Line 16: boolean isForce = getParameters().isForce(); Line 17: boolean supportForceCreateVolume = Line 18: GlusterFeatureSupported.glusterForceCreateVolumeSupported(getParameters().getClusterVersion()); If the user passes force = true, and the feature is not supported in the cluster version, is there a way for user to know that force option was ignored? Line 19: List<String> bricks = GlusterCoreUtil.getQualifiedBrickList(getParameters().getBricks()); Line 20: status = supportForceCreateVolume ? Line 21: getBroker().glusterVolumeBrickAdd(getParameters().getVolumeName(), Line 22: bricks.toArray(new String[0]), -- To view, visit http://gerrit.ovirt.org/21403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I65b3e96d759a0b09b625da793b6c63b93f8c2131 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
