Omer Frenkel has posted comments on this change.

Change subject: gluster: fill task parameters in async task status query
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterAsyncTaskStatusQueryBase.java
Line 110:     private void updateLatestStatus(GlusterVolumeTaskStatusEntity 
status) {
Line 111:         GlusterAsyncTask asyncTask = volume.getAsyncTask();
Line 112:         GlusterTaskParameters taskParameters = new 
GlusterTaskParameters();
Line 113:         taskParameters.setVolumeName(volume.getName());
Line 114:         asyncTask.setTaskParameters(taskParameters);
no chance there are already other parameters there?
Line 115: 
Line 116:         if (asyncTask != null && asyncTask.getTaskId() != null) {
Line 117:             List<Step> stepsList = 
getStepDao().getStepsByExternalId(asyncTask.getTaskId());
Line 118: 


-- 
To view, visit http://gerrit.ovirt.org/22083
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3cf2f7cc9f633d99a673879a0876919ead5fb843
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to