Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: increase memory threshold check to 10%
......................................................................
Patch Set 3:
(3 comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/system/memcheck.py
Line 59: if self._total_memory < self.environment[
Line 60: osetupcons.SystemEnv.MEMCHECK_MINIMUM_MB
Line 61: ] * self.environment[
Line 62: osetupcons.SystemEnv.MEMCHECK_THRESHOLD
Line 63: ]:
/ 100 ?
Line 64: self.logger.warn(
Line 65: _(
Line 66: 'Warning: Not enough memory is available on the
host. '
Line 67: 'Minimum requirement is {minimum}MB, and
{recommended}MB '
Line 80: if self._total_memory < self.environment[
Line 81: osetupcons.SystemEnv.MEMCHECK_RECOMMENDED_MB
Line 82: ] * self.environment[
Line 83: osetupcons.SystemEnv.MEMCHECK_THRESHOLD
Line 84: ]:
/ 100 ?
Line 85: self.logger.warn(
Line 86: _(
Line 87: 'Less than {recommended}MB of memory is
available'
Line 88: ).format(
Line 109: osetupcons.SystemEnv.MEMCHECK_RECOMMENDED_MB,
Line 110: osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_RECOMMENDED_MB
Line 111: )
Line 112: self.environment.setdefault(
Line 113: osetupcons.SystemEnv.MEMCHECK_THRESHOLD,
no no... the whole point is that the environment will not contain float.
Line 114:
float(osetupcons.Defaults.DEFAULT_SYSTEM_MEMCHECK_THRESHOLD) / 100
Line 115: )
Line 116:
Line 117: @plugin.event(
--
To view, visit http://gerrit.ovirt.org/22091
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5fa5ca2fd74940df47e4f137efb8346abcdc4814
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
