Allon Mureinik has posted comments on this change.
Change subject: engine: Improve log message on failure to connect to storage
server
......................................................................
Patch Set 3: Code-Review-1
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectSingleAsyncOperation.java
Line 17: try {
Line 18:
StorageHelperDirector.getInstance().getItem(getStorageDomain().getStorageType())
Line 19: .connectStorageToDomainByVdsId(getStorageDomain(),
getVdss().get(iterationId).getId());
Line 20: } catch (RuntimeException e) {
Line 21: log.errorFormat("Failed to connect host {0} to storage
server (name: {1}, id: {2}). Exception: {3}",
name/id here are misleading - these are not the name/id of the storage server.
Please replace them with domain name/id.
Line 22: getVdss().get(iterationId).getName(),
getStorageDomain().getName(), getStorageDomain().getId(), e);
Line 23: }
Line 24: }
Line 25:
Line 18:
StorageHelperDirector.getInstance().getItem(getStorageDomain().getStorageType())
Line 19: .connectStorageToDomainByVdsId(getStorageDomain(),
getVdss().get(iterationId).getId());
Line 20: } catch (RuntimeException e) {
Line 21: log.errorFormat("Failed to connect host {0} to storage
server (name: {1}, id: {2}). Exception: {3}",
Line 22: getVdss().get(iterationId).getName(),
getStorageDomain().getName(), getStorageDomain().getId(), e);
Nit: perhaps it's worth extracting getVdss().get(iterationId) to a variable
before the try clause?
Line 23: }
Line 24: }
Line 25:
Line 26: private static Log log =
LogFactory.getLog(ConnectSingleAsyncOperation.class);
--
To view, visit http://gerrit.ovirt.org/22133
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife941b59766e699a046122abc74aaede366a2015
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
