Mike Kolesnik has posted comments on this change.
Change subject: engine: Introduce PersistentSetupNetworksCommand
......................................................................
Patch Set 2:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/host/PersistentSetupNetworksCommand.java
Line 24:
Line 25: @Override
Line 26: protected void executeCommand() {
Line 27: VdcReturnValueBase returnValue =
getBackend().runInternalAction(VdcActionType.SetupNetworks, getParameters());
Line 28: if (returnValue.getSucceeded()) {
What if failed? Shouldn't call propagateFailure()?
Line 29:
getBackend().runInternalAction(VdcActionType.CommitNetworkChanges,
Line 30: new
VdsActionParameters(getParameters().getVdsId()));
Line 31: }
Line 32: }
Line 26: protected void executeCommand() {
Line 27: VdcReturnValueBase returnValue =
getBackend().runInternalAction(VdcActionType.SetupNetworks, getParameters());
Line 28: if (returnValue.getSucceeded()) {
Line 29:
getBackend().runInternalAction(VdcActionType.CommitNetworkChanges,
Line 30: new
VdsActionParameters(getParameters().getVdsId()));
Should set the return value of the command to be the returned value of the
commit command?
propagateFailure() might be necessary here also..
Line 31: }
Line 32: }
--
To view, visit http://gerrit.ovirt.org/22051
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a29e970ecbf02a7a3387a26f482de9200a3719
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
