Yair Zaslavsky has posted comments on this change. Change subject: tools: cleanup notifier. ......................................................................
Patch Set 3: (1 comment) I would elaborate a bit more at the commit msg about the change that you made, I think i got it, but still - see my question, maybe a more detailed commit msg would have given you +1 by now :) .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/NotificationMethodsMapper.java Line 12: Line 13: private Map<EventNotificationMethods, EventSender> eventSenders = new HashMap<>(); Line 14: Line 15: public NotificationMethodsMapper(NotificationProperties prop) { Line 16: eventSenders.put(EventNotificationMethods.EMAIL, new EventMailSender(prop)); So basically we assume that there is at least one sender - an email sender, right? Line 17: } Line 18: Line 19: public EventSender getEventSender(EventNotificationMethods method) { Line 20: return eventSenders.get(method); -- To view, visit http://gerrit.ovirt.org/22135 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b71c4e78bbdca3d02d2ac4ef419b9d3d7d58761 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches