Sandro Bonazzola has posted comments on this change.

Change subject: packaging: setup: set cluster level CPU id
......................................................................


Patch Set 1:

(1 comment)

....................................................
File src/plugins/ovirt-hosted-engine-setup/engine/add_host.py
Line 435:                 self.logger.debug(cluster.__dict__)
Line 436:                 cpu = cluster.get_cpu()
Line 437:                 self.logger.debug(cpu.__dict__)
Line 438:                 
cpu.set_id(self.environment[ohostedcons.VDSMEnv.ENGINE_CPU])
Line 439:                 cluster.set_cpu(cpu)
Michael, what should be called here for updating the cluster in the manager?

Using clusters.add fails with cluster already exists.

And if I try to do this before adding the hosts cluster.get_cpu() returns None.
Line 440:             except ovirtsdk.infrastructure.errors.RequestError as e:
Line 441:                 self.logger.debug(
Line 442:                     'Cannot set the CPU level to the Default cluster',
Line 443:                     exc_info=True,


-- 
To view, visit http://gerrit.ovirt.org/22129
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I141304606f4a1f11bb0f9fda8b1c822669d560c8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-hosted-engine-setup
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Adam Litke <ali...@redhat.com>
Gerrit-Reviewer: Alex Lourie <alou...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to