Ravi Nori has uploaded a new change for review.

Change subject: webadmin: Add host/Reinstall radio button text not actionable
......................................................................

webadmin: Add host/Reinstall radio button text not actionable

The radio buttons in Add/Reinstall host dialogs to select
between password and SSH Key are not actionable. You can
only click the radio button to change selection but not
the text.

Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804
Bug-Url: https://bugzilla.redhat.com/1035844
Signed-off-by: Ravi Nori <rn...@redhat.com>
---
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
M 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/28/22128/1

diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
index 86e508f..e651d07 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.java
@@ -520,6 +520,8 @@
         hostAddressEditor.setLabel(constants.hostPopupHostAddressLabel());
         authSshPortEditor.setLabel(constants.hostPopupPortLabel());
         authLabel.setText(constants.hostPopupAuthLabel());
+        rbPassword.setText(constants.hostPopupPasswordLabel());
+        rbPublicKey.setText(constants.hostPopupPublicKeyLable());
 
         fingerprintLabel.setText(constants.hostPopupHostFingerprintLabel());
         
overrideIpTablesEditor.setLabel(constants.hostPopupOverrideIpTablesLabel());
diff --git 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
index 80e261f..a4dcd0b 100644
--- 
a/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
+++ 
b/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostPopupView.ui.xml
@@ -253,12 +253,10 @@
                                         <e:EntityModelTextBoxEditor 
ui:field="userNameEditor"/>
                                         <g:HorizontalPanel 
ui:field="passwordSection" width="100%" verticalAlignment="middle">
                                             <g:RadioButton 
ui:field="rbPassword" />
-                                            <g:Label 
text="{constants.hostPasswordLabel}" />
                                             <e:EntityModelPasswordBoxEditor 
ui:field="passwordEditor"/>
                                         </g:HorizontalPanel>
                                         <g:HorizontalPanel 
ui:field="pkSection" width="100%" verticalAlignment="middle">
                                             <g:RadioButton 
ui:field="rbPublicKey" addStyleNames="{style.radioButton}" />
-                                            <g:Label 
text="{constants.hostPublicKeyLable}" />
                                             <e:EntityModelTextAreaLabelEditor 
ui:field="publicKeyEditor" />
                                         </g:HorizontalPanel>
                                         <d:AdvancedParametersExpander 
ui:field="expander"/>


-- 
To view, visit http://gerrit.ovirt.org/22128
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2baad8ec5f50b7022a348d6ef236691b3feaa804
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to