Yair Zaslavsky has posted comments on this change. Change subject: tools: Fixing edit action of manage-domains ......................................................................
Patch Set 2: (1 comment) .................................................... File backend/manager/tools/src/main/java/org/ovirt/engine/core/domains/ManageDomains.java Line 528: authModeEntry.setValueForDomain(domainName, authMode); Line 529: ldapProviderTypesEntry.setValueForDomain(domainName, ldapProviderType.name()); Line 530: Line 531: String ldapServersStr = parser.getArg(Arguments.ldapServers.name()); Line 532: setLdapServersPerDomain(domainName, ldapServersEntry, ldapServersStr); But this is in add domain action - not edit. So why is it a bug? if there is -ldapServers, DNS srv record query should not be issue. Line 533: Line 534: Line 535: testConfiguration(domainName, Line 536: domainNameEntry, -- To view, visit http://gerrit.ovirt.org/22063 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f86b8ce2c697931b9c8388ea87fe07d557530c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
