Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 30: (1 comment) minor comment, I would like to verify this myself tonight as well before merge. .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/process_firewalld_services.py Line 45: self._environment = environment Line 46: Line 47: @classmethod Line 48: def getInstance(clz, environment): Line 49: if Process._instance is None: if clz._instance. I will push another patch to fix that. Line 50: Process._instance = Process(environment=environment) Line 51: return Process._instance Line 52: Line 53: @property -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 30 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yedidyah Bar David <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
