Lior Vernia has posted comments on this change. Change subject: webadmin: Refactoring in VnicProfilesEditor ......................................................................
Patch Set 2: (1 comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NewNetworkModel.java Line 116 Line 117 Line 118 Line 119 Line 120 Since custom properties are not visible in NetworkModel (can be seen in the no-argument NewVnicProfileModel constructor invoked), there was no real point to update them. In other views of VnicProfileModel the DC cannot be modified, so there was no need to update anything other than the QoS list in NetworkProfilesModel.updateDcId(). -- To view, visit http://gerrit.ovirt.org/21629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8b101f869d90d5e10636ac70e653376dc29f72d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
