Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 26: (2 comments) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 217: # constants.Stages.IPTABLES_VALIDATION, Line 218: #), Line 219: # and remove: Line 220: priority=plugin.Stages.PRIORITY_HIGH, Line 221: ) why do we need the todo? why not do this now? hmmm see my comment at firewalld, we probably do not need it. Line 222: def _validation(self): Line 223: if self.environment[ Line 224: osetupcons.ConfigEnv.FIREWALL_MANAGER Line 225: ] not in [m.name for m in self._available_managers]: .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_firewalld.py Line 95: Line 96: def enable(self): Line 97: self.environment[otopicons.NetEnv.FIREWALLD_ENABLE] = True Line 98: # Actual preparation happens in _validation below, always - Line 99: # even if this manager is not active. but why not put the preparation here? you got access to environment and such? you can move it to some object method that is common to both enable and prepare and not relay on the flow of otopi just relay on the flow of the manager. for simplicity I do no care if it is done twice... while you can store it in member and protect second execution... Line 100: Line 101: def prepare_examples(self): Line 102: for service in self.environment[ Line 103: osetupcons.NetEnv.FIREWALLD_SERVICES -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 26 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
