Kanagaraj M has posted comments on this change.
Change subject: webadmin : Retain bricks refresh
......................................................................
Patch Set 4:
(2 comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeRebalanceStatusModel.java
Line 193: }
Line 194:
Line 195: public void setStopTimeVisible(boolean stopTimeVisible) {
Line 196: this.stopTimeVisible = stopTimeVisible;
Line 197: setStatusAvailable(false);
this is not required here, showStatus() does the same
Line 198: onPropertyChanged(new
PropertyChangedEventArgs("STOP_TIME_UPDATED"));//$NON-NLS-1$
Line 199: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumeRebalanceStatusPopupView.java
Line 208: public void eventRaised(Event ev, Object sender,
EventArgs args) {
Line 209: PropertyChangedEventArgs e =
(PropertyChangedEventArgs) args;
Line 210: if (e.PropertyName.equals("STATUS_UPDATED"))
{//$NON-NLS-1$
Line 211: status.setText(constants.rebalanceComplete());
Line 212: status.setVisible(object.isStatusAvailable());
only the visibility will be decided inside, setText can be moved to localize()
Line 213: } else if
(e.PropertyName.equals("STOP_TIME_UPDATED")) {//$NON-NLS-1$
Line 214:
stopTimePanel.setVisible(object.isStopTimeVisible());
Line 215: status.setVisible(object.isStatusAvailable());
Line 216: }
--
To view, visit http://gerrit.ovirt.org/21966
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iddc56eec6f9e456c6fdcf6dd45152b58fb0878ed
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Ramesh N <rnach...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
