Yedidyah Bar David has posted comments on this change.

Change subject: packaging: setup: update firewall for all services
......................................................................


Patch Set 23:

(2 comments)

....................................................
File 
packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_firewalld.py
Line 44:     Firewall manager firewalld plugin.
Line 45:     """
Line 46: 
Line 47:     @staticmethod
Line 48:     def parseFirewalld(format, environment, portSeparator='-'):
Done
Line 49:         ret = ''
Line 50:         for content in [
Line 51:             content
Line 52:             for key, content in environment.items()


....................................................
File 
packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager_human.py
Line 31: from ovirt_engine_setup import constants as osetupcons
Line 32: from ovirt_engine_setup import firewall_manager_base
Line 33: 
Line 34: 
Line 35: from . import firewall_manager_firewalld
Done
Line 36: 
Line 37: 
Line 38: @util.export
Line 39: class Plugin(plugin.PluginBase):


-- 
To view, visit http://gerrit.ovirt.org/20737
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9
Gerrit-PatchSet: 23
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to