Vered Volansky has posted comments on this change. Change subject: core: allow current master domain to be selected as the new master ......................................................................
Patch Set 6: (2 comments) Can't continue reviewing right now, so just comments on commit message. .................................................... Commit Message Line 17: Line 18: NOTE: in that case, the reconstruct command will be executed with Line 19: parameter indicating that the current master can be selected as the new Line 20: master - but the host that return the WrongMasterDomain error or the master Line 21: domain id as the master domain id as the id of the domain to reconstruct to aren't s/as the master domain id/ s/to aren't/<something else>, not sure what you mean to day here. Line 22: being passed to the command - this is being done to avoid possible Line 23: issues (for example: failing to reconstruct to that domain although we Line 24: can read the metadata, keep trying through the same host..etc). Line 25: The intention here is to improve the current situation for most of the Line 24: can read the metadata, keep trying through the same host..etc). Line 25: The intention here is to improve the current situation for most of the Line 26: usecases. Line 27: Line 28: 2. When the master domain info in the db is different then the s/then/than Line 29: info received from getStoragePoolInfo. Line 30: Line 31: Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Line 32: Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1016118 -- To view, visit http://gerrit.ovirt.org/22016 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705298d4f94b4afacc3ca028bb0a4e6080ac5a46 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
