Oved Ourfali has submitted this change and it was merged. Change subject: restapi: Remove spaces in realm specification ......................................................................
restapi: Remove spaces in realm specification The current basic authentication implementation adds spaces before and after the equals sign that goes after the "realm" specification in the "WWW-Authenticate" header. The RFC (see http://www.ietf.org/rfc/rfc2617.txt) does not explicitly states that spaces are not allowed here, but all the examples are without spaces. In addition the presence of spaces breaks some clients. Firefox, for example, will not display the realm name in the popup used to request the user name and password. Python urllib2 doesn't work at all. This patch removes those problematic spaces and fixes a minor spelling issue. Change-Id: Ida685483e5732fab2cacf96dae597a3199f3093d --- M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/security/auth/BasicAuthorizationScheme.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Juan Hernandez: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3925 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida685483e5732fab2cacf96dae597a3199f3093d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Ori Liel <ol...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
