Shubhendu Tripathi has uploaded a new change for review.

Change subject: gluster: Show correct step type for async tasks
......................................................................

gluster: Show correct step type for async tasks

Earlier the step type details for gluster async tasks was being shown as
UNKNOWN for steps like REBALANCING_VOLUME and REMOVE_BRICKS.
Corrected the same in StepMapper to correctly map to valid step type.

Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c
Bug-Url: https://bugzilla.redhat.com/1037709
Signed-off-by: Shubhendu Tripathi <shtri...@redhat.com>
---
M 
backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java
M 
backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
2 files changed, 15 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/64/22064/1

diff --git 
a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java
 
b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java
index c0077f0..dfb0e31 100644
--- 
a/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java
+++ 
b/backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/StepEnum.java
@@ -1,9 +1,12 @@
 package org.ovirt.engine.api.model;
 
+
 public enum StepEnum {
     VALIDATING,
     EXECUTING,
     FINALIZING,
+    REBALANCING_VOLUME,
+    REMOVING_BRICKS,
     UNKNOWN;
 
     public String value() {
diff --git 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
index 6eb54cc..0f0fd4c 100644
--- 
a/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
+++ 
b/backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/StepMapper.java
@@ -88,6 +88,12 @@
         if (StepEnum.FINALIZING.name().equals(type.name().toUpperCase())) {
             return org.ovirt.engine.core.common.job.StepEnum.FINALIZING;
         }
+        if 
(StepEnum.REBALANCING_VOLUME.name().equals(type.name().toUpperCase())) {
+            return 
org.ovirt.engine.core.common.job.StepEnum.REBALANCING_VOLUME;
+        }
+        if (StepEnum.REMOVING_BRICKS.name().equals(type.name().toUpperCase())) 
{
+            return org.ovirt.engine.core.common.job.StepEnum.REMOVING_BRICKS;
+        }
         return org.ovirt.engine.core.common.job.StepEnum.UNKNOWN;
     }
 
@@ -103,6 +109,12 @@
         if (StepEnum.FINALIZING.name().equals(type.name())) {
             return StepEnum.FINALIZING;
         }
+        if (StepEnum.REBALANCING_VOLUME.name().equals(type.name())) {
+            return StepEnum.REBALANCING_VOLUME;
+        }
+        if (StepEnum.REMOVING_BRICKS.name().equals(type.name())) {
+            return StepEnum.REMOVING_BRICKS;
+        }
         return StepEnum.UNKNOWN;
     }
 


-- 
To view, visit http://gerrit.ovirt.org/22064
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3cec46a382d05d9294bf7cca562167fd634ef63c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to