Darshan N has posted comments on this change.

Change subject: gluster: Proper checking before retriving volume in 
eventMessageLogger
......................................................................


Patch Set 2:

(1 comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/tasks/GlusterTaskUtils.java
Line 224:     public void eventMessageLogger(GlusterAsyncTask task, 
JobExecutionStatus oldStatus, VDSGroup cluster) {
Line 225:         GlusterVolumeEntity volume = 
getVolumeDao().getVolumeByGlusterTask(task.getTaskId());
Line 226:         if ( volume == null){
Line 227:             if(task.getTaskParameters() != null) {
Line 228:                 String vol = task.getTaskParameters().getVolumeName();
Done
Line 229:                 volume = getVolumeDao().getByName(cluster.getId(), 
vol);
Line 230:             }
Line 231:             else {
Line 232:                 return;


-- 
To view, visit http://gerrit.ovirt.org/21949
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I78367afc8771b2adb6b653f5d23bdbfe28e126d2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Darshan N <dnara...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to