Tomas Jelinek has posted comments on this change.
Change subject: webadmin: Small improvements to AddRemoveRowWidget
......................................................................
Patch Set 2:
(1 comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/AddRemoveRowWidget.java
Line 226: * @param widget
Line 227: * the widget added.
Line 228: */
Line 229: protected void onAdd(T value, V widget) {
Line 230: // do nothing
This should commit the change to the model immediately I would say. Also the
commit message says that...
Line 231: }
Line 232:
Line 233: /**
Line 234: * This method is called straight after an entry is removed by
pressing the minues button. Note that this entry will
--
To view, visit http://gerrit.ovirt.org/21627
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I645c6984f9bcfe6f00f8b7eb07313f4d4f3d7043
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
