Michael Pasternak has posted comments on this change.

Change subject: restapi: Fix broken path to the image under glance storage 
domain
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

+2, but please address my coment before merging

....................................................
File 
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainImagesResource.java
Line 63: 
Line 64:     @Override
Line 65:     protected Image addParents(Image image) {
Line 66:         image.setStorageDomain(new StorageDomain());
Line 67:         image.getStorageDomain().setId(storageDomainId.toString());
this is only a portion of URI and should not have anything, but the id,

please add

return super.addParents(image);
Line 68:         return image;
Line 69:     }


-- 
To view, visit http://gerrit.ovirt.org/21981
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I480e798e3c74af8357d48a1fd93a4ce4ae608383
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to