Allon Mureinik has uploaded a new change for review.

Change subject: core: rm unused methods from ErrorTranslator[Impl]
......................................................................

core: rm unused methods from ErrorTranslator[Impl]

Change-Id: Iff84d5cd7e9dc0690eff490c463ea9ebe36dfc97
Signed-off-by: Allon Mureinik <amure...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java
M 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
2 files changed, 0 insertions(+), 35 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/01/22001/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java
index 126695a..897f698 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/interfaces/ErrorTranslator.java
@@ -4,21 +4,6 @@
 import java.util.Locale;
 
 public interface ErrorTranslator {
-
-    /**
-     * Translate errors from error types. error messages contains errors and 
variables. Variable used in messages.
-     * Variable definition must be in format: $variableName variableValue. 
Variable usage must be in format
-     * #variableName
-     *
-     * @param errorMsg
-     *            messages to be translated
-     * @param changeIfNotFound
-     *            If true: if message key is not found in the resource, return 
a beautified key. If false, returned
-     *            unfound key as is.
-     * @return
-     */
-    List<String> TranslateErrorText(List<String> errorMsg, boolean 
changeIfNotFound);
-
     /**
      * Translates and resolves errors from error types. error messages 
contains errors and variables. Variable used in
      * messages. Variable definition must be in format: $variableName 
variableValue. Variable usage must be in format
@@ -42,8 +27,6 @@
      * @return
      */
     List<String> TranslateErrorText(List<String> errorMsg, Locale locale);
-
-    List<String> TranslateMessages(List<String> errorMsg, boolean 
changeIfNotFound);
 
     /**
      * returns true if the specified strMessage is in the format: 
"$variable-name variable-value", false otherwise.
diff --git 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
index 0c6b908..a2cc25a 100644
--- 
a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
+++ 
b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ErrorTranslatorImpl.java
@@ -70,15 +70,6 @@
         return messages;
     }
 
-    /*
-     * (non-Javadoc)
-     *
-     * @see 
org.ovirt.engine.core.utils.ErrorTranslator#TranslateErrorText(java.util.List, 
boolean)
-     */
-    public final List<String> TranslateErrorText(List<String> errorMsg, 
boolean changeIfNotFound) {
-        return translate(errorMsg, changeIfNotFound, Locale.getDefault());
-    }
-
     private final List<String> translate(List<String> errorMsg, boolean 
changeIfNotFound, Locale locale) {
         List<String> translatedMessages = doTranslation(errorMsg, 
changeIfNotFound, locale);
         return ResolveMessages(translatedMessages);
@@ -100,15 +91,6 @@
      */
     public List<String> TranslateErrorText(List<String> errorMsg, Locale 
locale) {
         return translate(errorMsg, true, locale);
-    }
-
-    /*
-     * (non-Javadoc)
-     *
-     * @see 
org.ovirt.engine.core.utils.ErrorTranslator#TranslateMessages(java.util.List, 
boolean)
-     */
-    public final List<String> TranslateMessages(List<String> errorMsg, boolean 
changeIfNotFound) {
-        return doTranslation(errorMsg, changeIfNotFound, Locale.getDefault());
     }
 
     public final List<String> doTranslation(List<String> errorMsg, boolean 
changeIfNotFound, Locale locale) {


-- 
To view, visit http://gerrit.ovirt.org/22001
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff84d5cd7e9dc0690eff490c463ea9ebe36dfc97
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amure...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to