Allon Mureinik has uploaded a new change for review. Change subject: core: rm useless ObjectIdentityChecker constructor ......................................................................
core: rm useless ObjectIdentityChecker constructor Since the previous patch removed the use of the status class, the constructor accepting it has become useless, and could safely be removed. Change-Id: Iedea2389028858ff474db032adc4ed8a5e7677db Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java 3 files changed, 2 insertions(+), 6 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/14/22014/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java index fc6a249..6b9896d 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java @@ -35,7 +35,7 @@ { Class<?>[] inspectedClasses = new Class<?>[] { VDS.class, VdsStatic.class, VdsDynamic.class }; mUpdateVdsStatic = - new ObjectIdentityChecker(VdsHandler.class, Arrays.asList(inspectedClasses), VDSStatus.class); + new ObjectIdentityChecker(VdsHandler.class, Arrays.asList(inspectedClasses)); for (Pair<EditableField, String> pair : extractAnnotatedFields(EditableField.class, inspectedClasses)) { diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java index 55a228f..0ffbfd2 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java @@ -89,7 +89,7 @@ osRepository = SimpleDependecyInjector.getInstance().get(OsRepository.class); mUpdateVmsStatic = - new ObjectIdentityChecker(VmHandler.class, Arrays.asList(inspectedClassNames), VMStatus.class); + new ObjectIdentityChecker(VmHandler.class, Arrays.asList(inspectedClassNames)); for (Pair<EditableField, String> pair : BaseHandler.extractAnnotatedFields(EditableField.class, (inspectedClassNames))) { diff --git a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java index 033551e..bfe82a8 100644 --- a/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java +++ b/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ObjectIdentityChecker.java @@ -34,10 +34,6 @@ } } - public ObjectIdentityChecker(Class<?> type, Iterable<Class<?>> aliases, Class<?> enumType) { - this(type, aliases); - } - public final void setContainer(IObjectDescriptorContainer value) { container = value; } -- To view, visit http://gerrit.ovirt.org/22014 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iedea2389028858ff474db032adc4ed8a5e7677db Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches