Alexander Wels has posted comments on this change.
Change subject: core: Automatic login filter
......................................................................
Patch Set 1:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AutomaticLoginFilter.java
Line 97: }
Line 98:
Line 99: // Check that the user exists in the directory associated to
the authentication profile:
Line 100: Directory directory = profile.getDirectory();
Line 101: DirectoryUser directoryUser = directory.findUser(loginName);
any possibility that directory can be null? if so there is a potential npe here.
Line 102: if (directoryUser == null) {
Line 103: log.info(
Line 104: "Can't login user \"{}\" with authentication profile
\"{}\" because the user doesn't exist in the " +
Line 105: "directory.",
--
To view, visit http://gerrit.ovirt.org/21023
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0b8cbee89b5bb96271c3706e9e75acbf2890a0b8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
