Yair Zaslavsky has posted comments on this change.
Change subject: core: Use new authentication interfaces
......................................................................
Patch Set 2:
(4 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddUserCommand.java
Line 43: if (directoryName == null) {
Line 44: log.error(
Line 45: "Can't add user because directory name hasn't been
provided."
Line 46: );
Line 47:
addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
I would suggest to use a different error message here - user must exist in
directory sounds to me like the directory exists, but the user does not exist
in it.
Line 48: return false;
Line 49: }
Line 50:
Line 51: // Check that the idientifier of the directory user has been
provided:
Line 66: "Can't add user with id \"{}\" because directory
\"{}\" doesn't exist.",
Line 67: id,
Line 68: directoryName
Line 69: );
Line 70:
addCanDoActionMessage(VdcBllMessages.USER_MUST_EXIST_IN_DIRECTORY);
same as before.
Line 71: return false;
Line 72: }
Line 73:
Line 74: // Check that the user is available in the directory (and save
the reference to avoid looking it up later when
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java
Line 102: updates.addAll(refreshed);
Line 103: }
Line 104:
Line 105: // Actually update the users in the database (note that this
should be done with a batch update, but we don't
Line 106: // have support for that yet):
+1 !
Line 107: for (DbUser dbUser : updates) {
Line 108: dao.update(dbUser);
Line 109: }
Line 110: }
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitBackendServicesOnStartupBean.java
Line 61: File etcDir = EngineLocalConfig.getInstance().getEtcDir();
Line 62: File authDir = new File(etcDir, "auth.d");
Line 63: if (authDir.exists() && authDir.isDirectory()) {
Line 64:
AuthenticationProfileManager.getInstance().loadConfiguration(authDir);
Line 65: }
Maybe extract all this code to some init method at AuthenticationProfileManager?
Line 66:
Line 67: // If no authentication profiles have been configured then
create one for each of the old style domains:
Line 68: if
(AuthenticationProfileManager.getInstance().getProfiles().isEmpty()) {
Line 69: for (String domain : LdapBrokerUtils.getDomainsList()) {
--
To view, visit http://gerrit.ovirt.org/20412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d5d6ee41b5373328eaf2f8448efe8e598609651
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Barak Azulay <[email protected]>
Gerrit-Reviewer: Liran Zelkha <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
