[Engine-patches] Change in ovirt-engine[master]: gluster: fix coverity defects

[masayag]

Moti Asayag has uploaded a new change for review.

Change subject: gluster: fix coverity defects
......................................................................

gluster: fix coverity defects

Coverity reports 2 issues:

** CID 1134449:  Se: Incorrect definition of Serializable clas
s  (FB.SE_COMPARATOR_SHOULD_BE_SERIALIZABLE): in line 66

** CID 1134450:  Bx: Questionable Boxing of primitive value
(FB.BX_BOXING_IMMEDIATELY_UNBOXED): in line 63

Change-Id: Id281b7c0d9500504b7f3201f6a16a1a7a26da56f
Signed-off-by: Moti Asayag <masa...@redhat.com>
---
M 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/24/21924/1

diff --git 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
index 6cd199a..94f3c98 100644
--- 
a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
+++ 
b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
@@ -1,5 +1,6 @@
 package org.ovirt.engine.core.common.utils;
 
+import java.io.Serializable;
 import java.util.ArrayList;
 import java.util.Collections;
 import java.util.Comparator;
@@ -60,10 +61,11 @@
                         Double.valueOf(SizeConverter.convert(size, inUnit, 
currentUnitPair.getSecond()).doubleValue()));
             }
         }
-        return new Pair<SizeConverter.SizeUnit, Double>(SizeUnit.BYTES, new 
Double(new Long(size)));
+        return new Pair<SizeConverter.SizeUnit, Double>(SizeUnit.BYTES, new 
Double(size));
     }
 
-    private static class CompareUnits implements Comparator<Pair<Long, 
SizeUnit>> {
+    private static class CompareUnits implements Comparator<Pair<Long, 
SizeUnit>>, Serializable {
+        private static final long serialVersionUID = -659222322712056953L;
 
         @Override
         public int compare(Pair<Long, SizeUnit> unit1, Pair<Long, SizeUnit> 
unit2) {


-- 
To view, visit http://gerrit.ovirt.org/21924
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id281b7c0d9500504b7f3201f6a16a1a7a26da56f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches