Alissa Bonas has uploaded a new change for review. Change subject: compat: remove unused methods in several classes ......................................................................
compat: remove unused methods in several classes Change-Id: Iece4ed1a69e0e648413468c229d4f2f05e5b172d Bug-Url: https://bugzilla.redhat.com/?????? Signed-off-by: Alissa Bonas <abo...@redhat.com> --- M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java 6 files changed, 0 insertions(+), 100 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/21918/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java index 79a7551..ecca4a8 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DateTime.java @@ -44,14 +44,6 @@ return DayOfWeek.forValue(this.getDay()); } - public long getTicks() { - return this.getTime(); - } - - public long getTotalMilliseconds() { - return this.getTime(); - } - public String toString(String formatString) { // c# compatibility boolean compat = false; @@ -90,13 +82,6 @@ return new TimeSpan(span); } - public DateTime AddSeconds(double secsSinceEpoch) { - Calendar cal = Calendar.getInstance(); - cal.setTime(this); - cal.add(Calendar.SECOND, (int) secsSinceEpoch); - return new DateTime(cal.getTime()); - } - /** * The Min Date in java * @@ -112,39 +97,11 @@ return new DateTime(System.currentTimeMillis()); } - public Date AddHours(int graceTime) { - Calendar cal = Calendar.getInstance(); - cal.setTime(this); - cal.add(Calendar.HOUR, graceTime); - return new DateTime(cal.getTime()); - } - - public DateTime AddMilliseconds(int interval) { - Calendar cal = Calendar.getInstance(); - cal.setTime(this); - cal.add(Calendar.MILLISECOND, interval); - return new DateTime(cal.getTime()); - } - public Date AddMinutes(int i) { Calendar cal = Calendar.getInstance(); cal.setTime(this); cal.add(Calendar.MINUTE, i); return new DateTime(cal.getTime()); - } - - public Date AddMinutes(double i) { - Calendar cal = Calendar.getInstance(); - cal.setTime(this); - cal.add(Calendar.MINUTE, (int) i); - return new DateTime(cal.getTime()); - } - - public static DateTime getUtcNow() { - Calendar cal = Calendar.getInstance(); - cal.add(Calendar.MILLISECOND, -cal.get(Calendar.DST_OFFSET) - cal.get(Calendar.ZONE_OFFSET)); - return new DateTime(cal.getTime()); - } public static String getDayOfTheWeekAsString(int dayOfTheWeek) { diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java index 643e2a3..0ea81ac 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/IntegerCompat.java @@ -20,15 +20,4 @@ } } - /** - * Compare two integers safely even if one or both are nulls - */ - public static boolean equalsWithNulls(Integer i1, Integer i2) { - if (i1 == null && i2 == null) - return true; // both nulls - if (i1 == null || i2 == null) - return false; // one is null the other is not - return i1.equals(i2); // both are not nulls - } - } diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java index fb1f335..bb5d0a1 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NotImplementedException.java @@ -10,15 +10,8 @@ super(); } - public NotImplementedException(String message, Throwable cause) { - super(message, cause); - } - public NotImplementedException(String message) { super(message); } - public NotImplementedException(Throwable cause) { - super(cause); - } } diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java index e70a683..b609d3c 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/StringHelper.java @@ -123,38 +123,6 @@ return trim(s, chars); } - public static String padLeft(String value, int length, char c) { - StringBuilder builder = new StringBuilder(value); - while (builder.length() < length) { - builder.insert(0, c); - } - - return builder.toString(); - } - - /** - * Aggregate String using the given char separator - * - * @param messgaes - * - the string to aggregate - * @param seperator - * - the separator to use between 2 strings - * @return the string separated by the give separator - */ - public static String aggregate(java.util.List<String> messages, char separator) { - if (messages == null) { - throw new IllegalArgumentException("The messages parameter can not be null"); - } - StringBuffer fullString = new StringBuffer(); - if (messages.size() > 0) { - for (String msg : messages) { - fullString.append(msg).append(separator); - } - fullString.deleteCharAt(fullString.length() - 1); - } - return fullString.toString(); - } - // ------------------------------------------------------------------------------------ // This method is used for string equality comparisons when the option // 'Use helper 'stringsEqual' method to handle null strings' is selected diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java index f53eb4f..ec6d1f6 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyInfo.java @@ -34,7 +34,4 @@ return pd.getWriteMethod() != null; } - public boolean isPropertyInstanceOf(Class<?> clazz) { - return this.pd.getPropertyType().equals(clazz); - } } diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java index 24e3002..8463b20 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/XmlTextWriter.java @@ -122,10 +122,6 @@ WriteEndElement(); } - public void WriteAttributeString(String namespaceURI, String localName, int value) { - WriteAttributeString(namespaceURI, localName, Integer.toString(value)); - } - public String getStringXML() { try { writer.writeEndElement(); -- To view, visit http://gerrit.ovirt.org/21918 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iece4ed1a69e0e648413468c229d4f2f05e5b172d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
