Juan Hernandez has posted comments on this change. Change subject: packaging: Add support for custom java.security ......................................................................
Patch Set 2: (1 comment) .................................................... File packaging/services/ovirt-engine/ovirt-engine.py Line 364: if os.path.exists(javaSecurityFile): Line 365: self._engineArgs.extend([ Line 366: '-Djava.security.properties=%s' % javaSecurityFile Line 367: ]) Line 368: I don't see the relation to platform independence here. It is just about having an optional custom java.security file. If the file exists then the property is added, as simple as that. Line 369: # Add extra system properties provided in the configuration: Line 370: for engineProperty in shlex.split( Line 371: self._config.get('ENGINE_PROPERTIES') Line 372: ): -- To view, visit http://gerrit.ovirt.org/21826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b102dd1c0ccbd6e73f24598b13319e1d3640086 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches