Alissa Bonas has uploaded a new change for review. Change subject: frontend: ignore in findbugs EventArgs unconfirmed cast errors ......................................................................
frontend: ignore in findbugs EventArgs unconfirmed cast errors Fix several excludes that entered to the incorrect filter in patch http://gerrit.ovirt.org/#/c/21882/ Change-Id: Ifa069c39ec911e0b3c63bea4326f5996f5d4ae8c Signed-off-by: Alissa Bonas <abo...@redhat.com> --- M frontend/webadmin/modules/gwt-common/exclude-filters.xml M frontend/webadmin/modules/uicommonweb/exclude-filters.xml M frontend/webadmin/modules/webadmin/exclude-filters.xml 3 files changed, 67 insertions(+), 70 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/03/21903/1 diff --git a/frontend/webadmin/modules/gwt-common/exclude-filters.xml b/frontend/webadmin/modules/gwt-common/exclude-filters.xml index 40eb5d3..a45834b 100644 --- a/frontend/webadmin/modules/gwt-common/exclude-filters.xml +++ b/frontend/webadmin/modules/gwt-common/exclude-filters.xml @@ -292,74 +292,4 @@ <Bug pattern="BC_UNCONFIRMED_CAST"/> </Match> - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.EntityModel" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.ListModel" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.providers.NeutronAgentModel$2" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModel$2" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.vms.EditVmInterfaceModel" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceModel" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.userportal.uicommon.model.vm.HostPopupPresenterWidget$1" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.userportal.uicommon.model.vm.HostPopupPresenterWidget$4" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.SetupNetworksManagementPopupPresenterWidget$1" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.SetupNetworksManagementPopupPresenterWidget$1" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.AssignTagsPopupView$1" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.configure.RolePopupView$5" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.datacenter.RecoveryStorageConfirmationPopupView$1" /> - <Bug pattern="BC_UNCONFIRMED_CAST"/> - </Match> - </FindBugsFilter> diff --git a/frontend/webadmin/modules/uicommonweb/exclude-filters.xml b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml index e089fab..a92c1a2 100644 --- a/frontend/webadmin/modules/uicommonweb/exclude-filters.xml +++ b/frontend/webadmin/modules/uicommonweb/exclude-filters.xml @@ -9,4 +9,40 @@ <Class name="org.ovirt.engine.ui.uicommonweb.models.hosts.HostSetupNetworksModel" /> <Bug code="NP"/> </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.EntityModel" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.ListModel" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.hosts.HostInterfaceListModel" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.providers.NeutronAgentModel$2" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModel$2" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.vms.EditVmInterfaceModel" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.uicommonweb.models.vms.VmInterfaceModel" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + </FindBugsFilter> diff --git a/frontend/webadmin/modules/webadmin/exclude-filters.xml b/frontend/webadmin/modules/webadmin/exclude-filters.xml index ced7469..3a6a836 100644 --- a/frontend/webadmin/modules/webadmin/exclude-filters.xml +++ b/frontend/webadmin/modules/webadmin/exclude-filters.xml @@ -250,4 +250,35 @@ <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.tab.MainTabVnicProfilePresenter$VnicProfileSelectionChange" /> <Bug code="UuF"/> </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.SetupNetworksManagementPopupPresenterWidget$1" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.AssignTagsPopupView$1" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.configure.RolePopupView$5" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.view.popup.datacenter.RecoveryStorageConfirmationPopupView$1" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.HostPopupPresenterWidget$1" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + + <Match> + <Class name="org.ovirt.engine.ui.webadmin.section.main.presenter.popup.host.HostPopupPresenterWidget$4" /> + <Bug pattern="BC_UNCONFIRMED_CAST"/> + </Match> + </FindBugsFilter> -- To view, visit http://gerrit.ovirt.org/21903 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifa069c39ec911e0b3c63bea4326f5996f5d4ae8c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abo...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
