Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: update firewall for all services ......................................................................
Patch Set 11: (1 comment) .................................................... File packaging/setup/plugins/ovirt-engine-setup/network/firewall_manager.py Line 232: ), Line 233: prompt=True, Line 234: validValues=managers, Line 235: caseSensitive=False, Line 236: default=(active_managers + managers)[0], I repeat comment from previous patches: I want simpler algorithm... this what I always want. The following is not something I understand: (active_managers + managers)[0] Please try to adjust the code to 'supported', 'available', 'selected' and see what you ends with. As far as I understand you use another variable 'detected' just to print what you found, but there is no reason to mix between these, and you can print the 'detected' as simple note. available = set(supported) - set(detected) selected = available[n] Line 237: ) Line 238: Line 239: for manager in managers: Line 240: if response.lower() == manager.lower(): -- To view, visit http://gerrit.ovirt.org/20737 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3c1a634b2e8539ebd604205b5487290c8d8a1a9 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
