anmolbabu has posted comments on this change.
Change subject: gluster : In the task tab, size of rebalanced files is shown
with units
......................................................................
Patch Set 24:
(2 comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/SizeConverter.java
Line 11: public static final long BYTES_IN_KB = 1024L;
Line 12: public static final long BYTES_IN_MB = 1024L * 1024L;
Line 13: public static final long BYTES_IN_GB = 1024L * 1024L * 1024L;
Line 14:
Line 15: public static Map<Long, SizeUnit> weightToUnit = new TreeMap<Long,
SizeUnit>(new CompareUnits());
Done
Line 16:
Line 17: public SizeConverter() {
Line 18:
Line 19: }
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterTasksListReturnForXmlRpc.java
Line 74: NumberFormat formatSize = NumberFormat.getInstance();
Line 75: formatSize.setMaximumFractionDigits(2);
Line 76: formatSize.setMinimumFractionDigits(2);
Line 77: Pair<SizeConverter.SizeUnit, Double> sizeMoved=
SizeConverter.autoConvert(size, SizeUnit.BYTES);
Line 78: return
formatSize.format(sizeMoved.getSecond().doubleValue()).toString().concat("").concat(sizeMoved.getFirst().toString());
Should have been a space instead of a blank "" actually :)
Line 79: }
Line 80:
Line 81: private String[] getBrickNames(Object bricksObj){
Line 82: if (bricksObj == null || !(bricksObj instanceof Object[])) {
--
To view, visit http://gerrit.ovirt.org/20511
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea6c90a098bfddfb616bc2b8ce58c9d0bb567f66
Gerrit-PatchSet: 24
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Sahina Bose <sab...@redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com>
Gerrit-Reviewer: anmolbabu <anb...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
