Eli Mesika has posted comments on this change.

Change subject: core: Added GetVmDataByPoolIdQuery
......................................................................


Patch Set 2: (2 inline comments)

....................................................
File backend/manager/dbscripts/vm_pools_sp.sql
Line 421:      FROM vms WHERE vm_pool_id = vm_pool_id
should be where vm_pool_id = v_pool_id

Line 425:      LIMIT 1;
Why are you limiting the results ?

--
To view, visit http://gerrit.ovirt.org/4024
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I390c9b49add6d004b1dc06e0e10eaf115c24243e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tni...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Eli Mesika <emes...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Tal Nisan <tni...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to