Alon Bar-Lev has posted comments on this change. Change subject: engine: Add infrastructure code for removal of parameter classes ......................................................................
Patch Set 20: (1 comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/Parameter.java Line 12: private static final String SERIALIZE_UUID_KEY = "uuid"; Line 13: private static final Map<UUID, Parameter> parametersMap = new HashMap<UUID, Parameter>(); Line 14: Line 15: private String name; Line 16: private transient Class javaType; this is strange... as it must have something called to perform deserialization.... can you please ask votech? Line 17: private String javaTypeName; Line 18: private UUID uuid; Line 19: Line 20: /** -- To view, visit http://gerrit.ovirt.org/20414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6a0970e492c0eff561888a46b02e47645ff68fc3 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
