Alon Bar-Lev has posted comments on this change.
Change subject: engine : Change parameter type of CommandBase
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
Line 34: public VdcActionParametersBase(ParametersMap map) {
Line 35: for (Map.Entry<Parameter, Serializable> entry :
map.entrySet()) {
Line 36:
put(Parameter.getByUuid(entry.getKey().getUuid().toString()), entry.getValue());
Line 37: }
Line 38: }
this I need to understand... let's discuss this on the VdcParameter at
infrastructure, as I think it should be done automatically while de-serialized.
Line 39:
Line 40: public Guid getCommandId() {
Line 41: return this.<Guid>get(CoreParameters.COMMAND_ID);
Line 42: }
--
To view, visit http://gerrit.ovirt.org/21319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c702d8f4184f08690d38902593bb4b733c69d95
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
