Omer Frenkel has posted comments on this change.
Change subject: core: check vds status on resume paused VM
......................................................................
Patch Set 8:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/RunVmValidator.java
Line 264: }
Line 265:
Line 266: protected ValidationResult validateVdsStatus(VM vm) {
Line 267: if (vm.getStatus() == VMStatus.Paused && vm.getRunOnVds() !=
null) {
Line 268: if (getVds(vm.getRunOnVds()).getStatus() != VDSStatus.Up)
{
you could merge the 2 'if' statements to one, also maybe better just to get the
vds dynamic if only status is used
Line 269: return new ValidationResult(
Line 270:
VdcBllMessages.ACTION_TYPE_FAILED_VDS_STATUS_ILLEGAL,
Line 271:
VdcBllMessages.VAR__HOST_STATUS__UP.toString());
Line 272: }
--
To view, visit http://gerrit.ovirt.org/18245
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac123f1758e5ed3dcedab335546df322fd76a0af
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
