Ravi Nori has posted comments on this change. Change subject: core: cleanup: remove tabs ......................................................................
Patch Set 1: (7 comments) .................................................... File frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/DateTime.java Line 9: public class DateTime extends Date { Line 10: Line 11: //public static Date Now = new DateTime(); Line 12: // public static DateTime Now2 = new DateTime(); Line 13: Please remove spaces Line 14: private static final String dayNames[] = EnumCompat.GetNames(DayOfWeek.class); Line 15: Line 16: public DateTime(int year, int month, int date) { Line 17: this(new Date(year, month, date)); Line 52: { Line 53: formatString = "yyyy-MM-ddHH:mm:ss"; Line 54: compat = true; Line 55: } Line 56: Please remove spaces Line 57: //TODO: GWT-TODO should be replaced Line 58: /* Line 59: SimpleDateFormat fmt = new SimpleDateFormat(formatString) ; Line 60: String returnedValue = fmt.format(this); .................................................... File frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/TimeSpan.java Line 85: if (cleaned.contains("-")) { Line 86: multiplier = -1 ; Line 87: cleaned = cleaned.replace("-", "").trim() ; Line 88: } Line 89: Please remove spaces Line 90: RegExp r = RegExp.compile("^[0-9]+$"); Line 91: if (r.test(cleaned)) { Line 92: int days = Integer.parseInt(cleaned) ; Line 93: return new TimeSpan(days * multiplier, 0, 0, 0) ; Line 152: result = 0; Line 153: } Line 154: return result; Line 155: } Line 156: Please remove spaces .................................................... File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/FrontendActionAsyncResult.java Line 48: setActionType(actionType); Line 49: setParameters(parameters); Line 50: setReturnValue(returnValue); Line 51: } Line 52: Please remove spaces Line 53: public FrontendActionAsyncResult(VdcActionType actionType, VdcActionParametersBase parameters, VdcReturnValueBase returnValue, Object state) Line 54: { Line 55: setActionType(actionType); Line 56: setParameters(parameters); .................................................... File frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Task.java Line 7: } Line 8: Line 9: private ITaskTarget target; Line 10: private TaskContext context; Line 11: Please remove spaces Line 12: private Task(ITaskTarget target, Object state) Line 13: { Line 14: this.target = target; Line 15: Line 11: Line 12: private Task(ITaskTarget target, Object state) Line 13: { Line 14: this.target = target; Line 15: Please remove spaces Line 16: context = new TaskContext(Dispatcher.CurrentDispatcher, state); Line 17: } Line 18: Line 19: public void Run() -- To view, visit http://gerrit.ovirt.org/21810 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53f42834829fc4d3d743cb25e80a8af03944fba9 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Ravi Nori <rn...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches