Alon Bar-Lev has posted comments on this change.
Change subject: engine : Validate parameter in canDoAction
......................................................................
Patch Set 7:
(1 comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/ParametersValidator.java
Line 61: if (fieldAnnotation != null) {
Line 62: try {
Line 63:
cmdParams.get(fieldAnnotation.optional()).addAll(Arrays.asList((Parameter[])
field.get(cmd)));
Line 64: } catch (IllegalAccessException e) {
Line 65: log.warn("Unable to retrieve parameters for "
+ clz.getName() + "." + field.getName());
this is like internal error, command should abort or anything similar... it is
higher than warning.
Line 66: }
Line 67: }
Line 68: }
Line 69: clz = clz.getSuperclass();
--
To view, visit http://gerrit.ovirt.org/21485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15566c9177da28b2d47bbb6018fbfb61defcf3da
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
