Alon Bar-Lev has posted comments on this change.
Change subject: engine : Remove StopVmParameters from StopVmCommand
......................................................................
Patch Set 15:
(2 comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java
Line 164:
Line 165: private VdcActionParametersBase
getParentActionParameters(ParametersMap map) {
Line 166: VdcActionParametersBase parentParams = new
VdcActionParametersBase();
Line 167: for (Map.Entry<Parameter, Serializable> entry :
map.entrySet()) {
Line 168:
parentParams.put(Parameter.getByUuid(entry.getKey().getUuid().toString()),
entry.getValue());
is this plain clone of map? if so why not just clone and setParameters() on
dest object?
Line 169: }
Line 170: return parentParams;
Line 171: }
Line 172:
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VmOperationParameterBase.java
this is temporary, right?
any reason not to remove this class before applying this patch?
Line 1: package org.ovirt.engine.core.common.action;
Line 2:
Line 3: import org.ovirt.engine.core.common.utils.VirtParameters;
Line 4: import org.ovirt.engine.core.common.utils.StorageParameters;
--
To view, visit http://gerrit.ovirt.org/20479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I404816e3e70ce044e1348af0eeea18b59e521581
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com>
Gerrit-Reviewer: Ravi Nori <rn...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
